libazureinit: remove requirement of minimum Rust version#92
Merged
dongsupark merged 1 commit intoAzure:mainfrom Jun 26, 2024
Merged
libazureinit: remove requirement of minimum Rust version#92dongsupark merged 1 commit intoAzure:mainfrom
dongsupark merged 1 commit intoAzure:mainfrom
Conversation
Replace inspect_err with map_err, to remove requirement of the minimum Rust version from 1.76, which is apparently not wide-spread enough in other development environments. See also Azure#84 (review).
dongsupark
changed the title
dongsupark
force-pushed
the
lower-minimum-rustver
branch
from
23532c9 to
467ec87
Compare
Closed
jeremycline
approved these changes
Jun 26, 2024
Member
jeremycline
left a comment
jeremycline
left a comment
There was a problem hiding this comment.
I guess we'll need to eventually settle on MSRV and add it to CI. I filed an issue about that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
inspect_errwithmap_err, to remove requirement of the minimum Rust version from 1.76, which is apparently not wide-spread enough in other development environments.See also #84 (review).
/cc @SeanDougherty